suppress pytest rewrite assertion warning #1279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Failures are due to latest mypy type checks, not related to this PR.... |
ikappaki
force-pushed
the
issue/basilisp-test-warning-semi
branch
from
c5cae99 to
ce4d6c8
Compare
|
Thanks @chrisrink10! Updating fixed the linting issue and all test pass now 🙌 |
chrisrink10
reviewed
Oct 29, 2025
chrisrink10
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
can you please consider patch to suppress the pytest rewrite assertion warning when running
basilisp test. It fixes #1252.I haven’t added a test, as it would require creating a virtual environment during testing, which seemed excessive for this issue. However, I’m happy to add one if you feel it’s necessary.
Thanks
Note: this is a follow up to #1255 but it uses the
;separator to specify the module name, introduced by pytest-dev/pytest#13429 in Pytest 8.4.0.